Ticket #73 (closed Defect: fixed)

Opened 4 months ago

Last modified 3 months ago

PackageDesktop should fully replace Summary and DisplayName

Reported by: Jan-Nik Assigned to: isak
Priority: Medium Milestone: 1.2.5
Component: devtools Version: 1.2.4
Severity: Minor Keywords:
Cc:

Description

As I see it, it's currently only possible to get the translations of "Summary" and "DisplayName" from a .desktop file via the PackageDesktop option.

IRC discussion

Attachments

desktop.diff (3.3 kB) - added by Jan-Nik on 04/20/08 13:06:59.
Only fail when both PackageDesktop and DisplayName are missing; set $PACKAGENAME after reading DisplayName from desktop file
desktop.2.diff (3.6 kB) - added by Jan-Nik on 04/22/08 14:56:14.
updated patch

Change History

04/20/08 13:06:59 changed by Jan-Nik

  • attachment desktop.diff added.

Only fail when both PackageDesktop and DisplayName are missing; set $PACKAGENAME after reading DisplayName from desktop file

04/22/08 14:12:03 changed by isak

  • status changed from new to assigned.
  • owner changed from Jan-Nik to isak.

Why does the patch contain modifications to the PackageFileName code? Can I safely ignore that when committing this?

04/22/08 14:24:46 changed by Jan-Nik

That's because currently makepackage sets PACKAGEFILENAME before reading the desktop file.

original order: [set PackageFileName] [read PackageDesktop] [use PackageFileName]

order ofter the patch: [read PackageDesktop] [set PackageFileName] [use PackageFileName]

04/22/08 14:28:02 changed by Jan-Nik

(if i wouldn't change the order it would result in a .package file named " 1.0.package", without the DisplayName)

04/22/08 14:35:34 changed by isak

Ah, ok. I understand.

This brings me to another question/comment. We'd need a check somewhere after we've parsed the .desktop file in order to make sure there actually is a .desktop file and that it contains a usable Name key.

04/22/08 14:56:14 changed by Jan-Nik

  • attachment desktop.2.diff added.

updated patch

05/05/08 14:16:20 changed by isak

  • status changed from assigned to closed.
  • resolution set to fixed.

Last patch applied in r2446. Thanks!