Ticket #63 (closed Defect: fixed)

Opened 9 months ago

Last modified 2 months ago

/dev/tty redirection in relaytool breaks under some circumstances

Reported by: caedes Assigned to: taj
Priority: Medium Milestone: 1.3
Component: apbuild Version: 1.2.4
Severity: Normal Keywords:
Cc:

Description

Hi, i have the following error on a compilation:

./bin/relaytool: line 534: /dev/tty: No such device or address

(from http://launchpadlibrarian.net/11120438/buildlog_ubuntu-hardy-lpia.crystalspace_1.2%2Bsvn28368-5_FAILEDTOBUILD.txt.gz)

i'm not sure if this can be solved by adding some extra software in the build environment, but maybe the redirection is not such a good idea in the first place (not sure).

note also the relaytool used is a patched version, but the redirection is also on your trunk, thus i write here.

greetings.

Attachments

relaytool-tty.diff (1.4 kB) - added by taj on 01/02/08 18:19:00.
relaytool-tty.2.diff (1.4 kB) - added by Jan-Nik on 08/03/08 12:53:55.

Change History

01/02/08 16:01:57 changed by taj

Thanks for the report! Could you please give the above patch a try and make sure it fixes the problem. They were the only 2 refs to /dev/tty in relaytool, so I think it should fix it.

01/02/08 18:19:00 changed by taj

  • attachment relaytool-tty.diff added.

01/07/08 14:56:22 changed by isak

  • milestone set to 1.2.5.

I have two questions about this issue:

1) Why do we force output to tty in the first place

and

2) If 1) has a reason, is outputting it to /dev/null a good solution if tty is missing? (e.g. why not just let it go to whatever stdout is attached to)

01/10/08 05:25:47 changed by caedes

i talked to the person compiling the code, and seems it is building in a chroot with no access to /dev at all, so better to just let it go (the maintainer said he replaced that with an echo.

08/01/08 20:02:18 changed by Jan-Nik

  • milestone changed from 1.2.6 to 1.3.

Milestone 1.2.6 deleted

08/03/08 12:53:55 changed by Jan-Nik

  • attachment relaytool-tty.2.diff added.

08/03/08 12:54:23 changed by Jan-Nik

What do you think about this patch?

08/03/08 13:16:13 changed by isak

I think relaytool-tty.2.diff is the way forward. Feel free to commit jan-nik

08/03/08 13:34:13 changed by Jan-Nik

  • status changed from new to closed.
  • resolution set to fixed.

Ok, r2491