Ticket #49 (closed Defect: fixed)

Opened 1 year ago

Last modified 2 months ago

makepackage can't read files with CRLFs

Reported by: blakemadden Assigned to: Jan-Nik
Priority: Medium Milestone: 1.3
Component: main Version: 1.2.4
Severity: Normal Keywords:
Cc:

Description (Last modified by isak)

I get an "No DisplayName key found in the [Meta] section" error message when I try to compile. Problem is, I do have this. This is what the top of my aspec file looks like: 

[Meta]
DisplayName:Readability Studio 2007
RootName: @oleandersolutions.com/readability-studio-2007:$SOFTWAREVERSION
ShortName: readability-studio-2007

What am I missing here?

Attachments

readstudio.apspec (0.9 kB) - added by blakemadden on 09/17/07 23:47:14.

Change History

09/17/07 11:45:56 changed by taj

Maybe I'm missing something...but is there a missing space between DisplayName: and Readability Studio? If you could add the whole specfile as an attachment, that would be great. Thanks, - Taj

09/17/07 23:47:14 changed by blakemadden

  • attachment readstudio.apspec added.

09/17/07 23:51:15 changed by blakemadden

I tried it both ways, with and without a space there.

I'm on OpenSuse? 10.2, I uninstalled whatever came with the system, and installed the lasted .package developer tools, so I should have everything set up correctly.

Thanks, Blake

09/18/07 22:40:53 changed by blakemadden

I see the problem now. makepackage fails if you have Windows CRLFs in your apspec file. I changed my file to use UNIX linefeeds instead and that fixed it.

09/21/07 10:52:54 changed by taj

  • priority changed from High to Medium.
  • severity changed from Critical to Normal.
  • summary changed from I get an "No DisplayName key found in the [Meta] section" error message. to makepackage can't read files with CRLFs.

We should fix that.

09/21/07 18:11:13 changed by isak

  • description changed.

05/10/08 22:03:45 changed by curtis

  • status changed from new to assigned.
  • owner changed from taj to curtis.
  • milestone set to 1.2.6.

Accept and add required milestone.

08/01/08 20:02:18 changed by Jan-Nik

  • milestone changed from 1.2.6 to 1.3.

Milestone 1.2.6 deleted

(follow-up: ↓ 9 ) 08/02/08 08:03:41 changed by Jan-Nik

  • status changed from assigned to new.
  • owner changed from curtis to Jan-Nik.

Is it okay if makepackage displays an error and asks if it should replace all CRLF with LF? The other way, really fixing the issue, seems impossible to me.

(in reply to: ↑ 8 ) 08/02/08 11:20:18 changed by isak

Replying to Jan-Nik:

Is it okay if makepackage displays an error and asks if it should replace all CRLF with LF? The other way, really fixing the issue, seems impossible to me.

In my opinion, yes. Can you reliably detect this?

Maybe using 'file': 

isak@skywalker ~ $ file default.apspec.*in 
default.apspec.dos.in: ASCII English text, with CRLF line terminators
default.apspec.in:     ASCII English text

08/02/08 12:07:27 changed by Jan-Nik

  • status changed from new to closed.
  • resolution set to fixed.

Ok, I committed a patch which displays a warning and gives the user a hint how to replace it with sed. r2485

08/02/08 12:59:40 changed by isak

Great work.

There's also the 'dos2unix' program available on many distros (debian has it, and I know I've used it on other distros too).

A minor usability concern only.. but I've always thought it impolite of a program to tell me exactly how to solve a problem but refusing to do it automatically. I mean, the program even knows the exact command, why not just run it :)

For that reason, it may be smarter to be a bit vague.. something like "You can use the dos2unix program, or use the 'Save As...' feature of your text editor to convert it to unix line endings"

Or maybe I'm just picky.. :)

08/02/08 13:12:53 changed by Jan-Nik

Good idea, I added a question in r2487.